Omniscia Euler Finance Audit

Code Style

Code Style

During the manual portion of the audit, we identified 32 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BFR-01CInefficient mapping Lookups
BUL-01CInefficient mapping Lookups
BUL-02CInexistent Propagation of Optimized Arithmetics
BPY-01CRepetitive Value Literal
BPY-02CUnconditional Appendment of Metadata
BUS-01CIneffectual Usage of Safe Arithmetics
BUS-02CInefficient Update of User's Debt
BUS-03CInefficient mapping Lookups
CEH-01CInconsistent Unwrapping Mechanism
CAT-01CRepetitive Value Literal
DHC-01CRedundant Copy of Call Data
ESH-01CIneffectual Usage of Safe Arithmetics
ESH-02CInefficient Loop Limit Evaluation
ESH-03CInefficient Structure Mutability Specifiers
ESH-04CLoop Iterator Optimization
GFY-01CGeneric Typographic Mistake
GFY-02CIneffectual Usage of Safe Arithmetics
GEC-01CInefficient Negation of Conditional
GEC-02CPotentially Misleading Variable Naming
GEC-03CRedundant Parenthesis Statement
IRL-01CIneffectual Usage of Safe Arithmetics
LTC-01CInefficient Conditional Exclusivity
LNO-01CRepetitive Value Literal
MPD-01CInefficient Memory Assignment
PSM-01CInefficient Re-Calculation of Fee Percentages
PCG-01COptimization of Structure Assignments
PCG-02CRepetitive Value Literal
PCG-03CVariable Grouping
STO-01CPotentially Inefficient Storage Structure
SEG-01CPotential Combination of Data Points
USE-01CInconsistent Bit Clearance Style
USE-02CRepetitive Value Literal