Omniscia Euler Finance Audit

Liquidation Code Style Findings

Liquidation Code Style Findings

LNO-01C: Repetitive Value Literal

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

src/EVault/modules/Liquidation.sol
129if (discountFactor < 1e18 - MAXIMUM_LIQUIDATION_DISCOUNT) {

Recommendation:

We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.

In case the constant has already been declared, we advise it to be properly re-used across the code.

Alleviation (fb2dd77a6ff9b7f710edb48e7eb5437e0db4fc1a):

The Euler Finance team evaluated this exhibit but opted to acknowledge it explicitly as they consider the current representation sufficient.