ProtocolConfig Static Analysis Findings

PCG-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		ProtocolConfig.sol:L55-L62

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
55constructor(address admin_, address feeReceiver_) {
56    admin = admin_;
57    feeReceiver = feeReceiver_;
58
59    minInterestFee = 0.1e4;
60    maxInterestFee = 1e4;
61    protocolFeeShare = 0.1e4;
62}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (fb2dd77a6ff9b7f710edb48e7eb5437e0db4fc1a):

All input arguments of the ProtocolConfig::constructor function are adequately sanitized as non-zero in the latest in-scope revision of the codebase, addressing this exhibit.