Omniscia Euler Finance Audit
Governance Static Analysis Findings
Governance Static Analysis Findings
GEC-01S: Inexistent Visibility Specifiers
Type | Severity | Location |
---|---|---|
Code Style | Governance.sol:L22, L23, L24 |
Description:
The linked variables have no visibility specifier explicitly set.
Example:
src/EVault/modules/Governance.sol
22uint16 constant MAX_PROTOCOL_FEE_SHARE = 0.5e4;
Recommendation:
We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma
versions.
Alleviation (fb2dd77a6ff9b7f710edb48e7eb5437e0db4fc1a):
The internal
visibility specifier has been introduced to all referenced variables, preventing potential compilation discrepancies and addressing this exhibit.