Omniscia Euler Finance Audit

LTVConfig Code Style Findings

LTVConfig Code Style Findings

LTC-01C: Inefficient Conditional Exclusivity

Description:

The first if clause within the LTVConfigLib::getLTV function is meant to yield the targetLTV immediately if it is greater than the originalLTV, however, the conditional is inefficient as the equality case is not covered.

Example:

src/EVault/shared/types/LTVConfig.sol
40function getLTV(LTVConfig memory self, LTVType ltvType) internal view returns (ConfigAmount) {
41    if (
42        ltvType == LTVType.BORROWING || block.timestamp >= self.targetTimestamp || self.targetLTV > self.originalLTV
43    ) {
44        return self.targetLTV;
45    }
46

47    uint256 ltv = self.originalLTV.toUint16();
48

49    unchecked {
50        uint256 timeElapsed = self.rampDuration - (self.targetTimestamp - block.timestamp);
51

52        // targetLTV < originalLTV and timeElapsed < rampDuration
53        ltv = ltv - ((ltv - self.targetLTV.toUint16()) * timeElapsed / self.rampDuration);
54    }
55    // because ramping happens only when LTV decreases, it's safe to down-cast the new value
56    return ConfigAmount.wrap(uint16(ltv));
57}

Recommendation:

We advise the code to yield the targetLTV if the targetLTV is greater-than-or-equal-to the originalLTV, optimizing the equality case's gas cost.

Alleviation (fb2dd77a6ff9b7f710edb48e7eb5437e0db4fc1a):

The conditional was updated to be inclusive in relation to its LTV comparison, optimizing the code's gas cost.

Prev

IRMLinearKink.sol (IRL-C)

Next

Liquidation.sol (LNO-C)

On this page