ActivePool Code Style Findings

APL-01C: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		ActivePool.sol:L19, L26, L30

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
19interface IERC20 {
20    function transfer(address recipient, uint256 amount) external returns (bool);
21    function transferFrom(address sender, address recipient, uint256 amount) external returns (bool);
22    function balanceOf(address account) external view returns (uint256);
23    function approve(address spender, uint256 amount) external returns (bool);
24}
25
26interface IAddPulseX {
27    function addPulseX(uint _amount) external returns (bool);
28}
29
30contract ActivePool is Ownable, CheckContract, IActivePool {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (8bedd3b0df6387957e6b8f5d52507e776c1458b0):

The Powercity team evaluated this exhibit but has opted to acknowledge it in the current iteration of the codebase.