PriceFeed Static Analysis Findings

PFD-01S: Illegible Numeric Value Representation

Type	Severity	Location
Code Style		PriceFeed.sol:L42

Description:

The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
42uint constant public TIMEOUT = 14400;  // 4 hours: 60 * 60 * 4

Recommendation:

To properly illustrate the value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation (8bedd3b0df6387957e6b8f5d52507e776c1458b0):

The Powercity team evaluated this exhibit but has opted to acknowledge it in the current iteration of the codebase.

PFD-02S: Inexistent Visibility Specifiers

Type	Severity	Location
Code Style		PriceFeed.sol:L32, L33

Description:

The linked variables have no visibility specifier explicitly set.

Example:

Copy
32address borrowerOperationsAddress;

Recommendation:

We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma versions.

Alleviation (8bedd3b0df6387957e6b8f5d52507e776c1458b0):

The referenced address members remain without a visibility specifier, rendering this exhibit acknowledged.