Omniscia Powercity Audit

CollSurplusPool Code Style Findings

CollSurplusPool Code Style Findings

CSP-01C: Multiple Top-Level Declarations

TypeSeverityLocation
Code StyleCollSurplusPool.sol:L11, L17

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

CollSurplusPool.sol
11interface IERC20 {
12 function transfer(address recipient, uint256 amount) external returns (bool);
13 function transferFrom(address sender, address recipient, uint256 amount) external returns (bool);
14 function balanceOf(address account) external view returns (uint256);
15 function approve(address spender, uint256 amount) external returns (bool);
16}
17contract CollSurplusPool is Ownable, CheckContract, ICollSurplusPool {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (8bedd3b0df6387957e6b8f5d52507e776c1458b0):

The Powercity team evaluated this exhibit but has opted to acknowledge it in the current iteration of the codebase.