TellorCaller Static Analysis Findings

TCR-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		TellorCaller.sol:L23-L25

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
23constructor (address _tellorMasterAddress) public {
24    tellor = ITellor(_tellorMasterAddress);
25}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (8bedd3b0df):

The input address of the TellorCaller::constructor remains unsanitized, rendering this exhibit acknowledged.

Alleviation (e1d571bb78):

The CheckContract has been imported to the TellorCaller codebase and its CheckContract::checkContract function is utilized, ensuring that the _tellorMasterAddress is a contract and thus addressing this exhibit.