Omniscia 0xPhase Audit
Manager Code Style Findings
Manager Code Style Findings
MRE-01C: Repetitive Value Literals
Type | Severity | Location |
---|---|---|
Code Style | Manager.sol:L24, L25, L27, L28, L31, L32 |
Description:
The linked value literals are repeated across the codebase multiple times.
Example:
core/Manager.sol
24address target = address(bytes20(data[offset:offset + 20]));
Recommendation:
We advise each to be set to its dedicated constant
variable instead optimizing the legibility of the codebase.
Alleviation (3dd3d7bf0c2693b2f9c23bacedfa420393f7ea84):
All referenced repetitive value literals have been relocated to contract-level constant
declarations that greatly increase the legibility of the codebase.