Omniscia 0xPhase Audit

VaultLiquidationFacet Code Style Findings

VaultLiquidationFacet Code Style Findings

VLF-01C: Suboptimal Struct Declaration Styles

TypeSeverityLocation
Code StyleVaultLiquidationFacet.sol:L85, L91, L119

Description:

The linked declaration styles of the referenced structs are using index-based argument initialization.

Example:

vault/diamond/VaultLiquidationFacet.sol
85return LiquidationInfo(true, 0, 0, 0, 0);

Recommendation:

We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.

Alleviation (3dd3d7bf0c2693b2f9c23bacedfa420393f7ea84):

All suboptimal declaration styles were replaced by the key-value declaration format, increasing the legibility of the codebase.