OwnableBase Manual Review Findings

OBE-01M: Inexistent Initialization of Ownership

Type	Severity	Location
Logical Fault		OwnableBase.sol:L24-L33

Description:

The OwnableBase contract does not contain any method to initialize its first ownership similarly to other facets of the system, such as ERC20Base::_initializeERC20.

Example:

Copy
6abstract contract OwnableBase {

Recommendation:

We advise the code to introduce an initialization mechanism meant to be invoked during the facet's registration to ensure that ownership is properly retained in the Diamond instance.

Alleviation (3dd3d7bf0c2693b2f9c23bacedfa420393f7ea84):

The code of OwnableBase was updated to expose a new Ownable::_initializeOwnable function that performs the correct initialization steps of the contract akin to the rest of the codebase. As such, we consider this exhibit fully alleviated.