Omniscia Bluejay Finance Audit

Code Style

Code Style

During the manual portion of the audit, we identified 22 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BBD-01CRedundant Entry Variable
BBD-02CSub-Optimal mapping Lookups
BGR-01CDuplicate Application of Modifier
BGR-02CInexistent Visibility Specifiers
BGR-03CRedundant Safe Arithmetics
BRR-01CInexistent Error Messages
PFO-01CInefficient Loop Limit Evaluation
PFO-02CInexistent Visibility Specifiers
PSR-01CInexistent Visibility Specifiers
SBD-01CInexistent Visibility Specifiers
SEE-01CAssignment Statement Optimization
SEE-02CInexistent Error Messages
SEE-03CInexistent Visibility Specifier
STN-01CInexistent Visibility Specifiers
STN-02CRedundant Safe Arithmetics
STN-03CVariable Mutability Specifiers
TBD-01CInexistent Visibility Specifiers
TBD-02CRedundant Duplicate Transfer
TOE-01CInexistent Visibility Specifier
TOE-02CPotentially Misleading Error Message
PAC-01CInexistent Visibility Specifier
WSP-01CInexistent Visibility Specifier

Prev

Manual Review

Next

BondGovernor.sol (BGR-S)