Omniscia Bluejay Finance Audit
PriceStabilizer Code Style Findings
PriceStabilizer Code Style Findings
PSR-01C: Inexistent Visibility Specifiers
Type | Severity | Location |
---|---|---|
Code Style | PriceStabilizer.sol:L13, L17 |
Description:
The linked variables have no visibility specifiers explicitly set.
Example:
packages/contracts/contracts/PriceStabilizer.sol
13uint256 constant WAD = 10**18;14bytes32 public constant MANAGER_ROLE = keccak256("MANAGER_ROLE");15bytes32 public constant OPERATOR_ROLE = keccak256("OPERATOR_ROLE");16
17IStablecoinEngine immutable stablecoinEngine;18mapping(address => PoolInfo) public poolInfos;
Recommendation:
We advise them to be set to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma
versions.
Alleviation:
Visibility specifiers have been introduced for both referenced variables alleviating this exhibit.