Omniscia Bluejay Finance Audit
BondRouter Code Style Findings
BondRouter Code Style Findings
BRR-01C: Inexistent Error Messages
Type | Severity | Location |
---|---|---|
Code Style | BondRouter.sol:L75, L76, L96, L97, L221, L229 |
Description:
The linked require
checks have no error messages explicitly defined.
Example:
packages/contracts/contracts/BondRouter.sol
75require(bondReserve[bond] != address(0));76require(bondType[bond] == BondType.TREASURY);
Recommendation:
We advise them to be set so to aid in the validation of the require
's condition as well as the legibility of the codebase.
Alleviation:
Error messages have been introduced throughout the code for the referenced require
checks thereby alleviating this exhibit.