Omniscia Bluejay Finance Audit
WhitelistSalePublic Static Analysis Findings
WhitelistSalePublic Static Analysis Findings
WSP-01S: Inexistent Event Emissions
Type | Severity | Location |
---|---|---|
Language Specific | WhitelistSalePublic.sol:L88-L90, L96-L98 |
Description:
The linked functions adjust sensitive contract variables yet do not emit an event for them.
Example:
packages/contracts/contracts/periphery/WhitelistSalePublic.sol
88function setPause(bool _paused) public onlyOwner {89 paused = _paused;90}91
92function setMerkleRoot(bytes32 _merkleRoot) public onlyOwner {93 _setMerkleRoot(_merkleRoot);94}95
96function setPrice(uint256 _price) public onlyOwner {97 price = _price;98}
Recommendation:
We advise an event to be coded and correspondingly emitted to ensure off-chain processes can properly react to these changes.
Alleviation:
Events and corresponding event emissions have been introduced throughout the relevant setter functions as advised.