Omniscia Bluejay Finance Audit
WhitelistSalePrivate Static Analysis Findings
WhitelistSalePrivate Static Analysis Findings
PAC-01S: Inexistent Event Emissions
| Type | Severity | Location |
|---|---|---|
| Language Specific |  | WhitelistSalePrivate.sol:L144-L146, L152-L154, L156-L158, L160-L162 |
Description:
The linked functions adjust sensitive contract variables yet do not emit an event for them.
Example:
packages/contracts/contracts/periphery/WhitelistSalePrivate.sol
144function setPause(bool _paused) public onlyOwner {145 paused = _paused;146}147
148function setMerkleRoot(bytes32 _merkleRoot) public onlyOwner {149 _setMerkleRoot(_merkleRoot);150}151
152function setPrice(uint256 _price) public onlyOwner {153 price = _price;154}155
156function setVestingStart(uint256 _vestingStart) public onlyOwner {157 vestingStart = _vestingStart;158}159
160function setVestingPeriod(uint256 _vestingPeriod) public onlyOwner {161 vestingPeriod = _vestingPeriod;162}Recommendation:
We advise an event to be coded and correspondingly emitted to ensure off-chain processes can properly react to these changes.
Alleviation:
Events and corresponding event emissions have been introduced throughout the relevant setter functions as advised.