Omniscia Bonq Audit

Code Style

Code Style

During the manual portion of the audit, we identified 21 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BON-01CDeprecated Numeric Representation
BON-02CRepetitive Value Literal
ARB-01CGeneric Typographic Mistakes
ARB-02CRedundant Logical Check
ARB-03CVariable Mutability Specifier (Immutable)
COM-01CVariable Mutability Specifiers (Immutable)
CON-01CDeprecated Numeric Representation
EXT-01CInefficient Loop Limit Evaluation
EXT-02CInefficient Ternary Operators
LIN-01CGeneric Typographic Mistakes
LIN-02CInconsistent Logical Checks
LIN-03CInefficient Utilization of Data Entries
LIN-04CInefficient mapping Lookups
MIT-01CVariable Mutability Specifier (Immutable)
PRI-01CGeneric Typographic Mistake
PRI-02CInefficient Loop Limit Evaluation
PRI-03CInefficient Ternary Operators
TOK-01CRepetitive Value Literal
TRE-01CVariable Mutability Specifiers (Immutable)
TRO-01CIneffectual Value Assignment
TRO-02CVariable Mutability Specifiers (Immutable)