Omniscia Bonq Audit
token-to-price-feed Code Style Findings
token-to-price-feed Code Style Findings
TOK-01C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style |  | token-to-price-feed.sol:L36, L38 |
Description:
The linked value literal is repeated across the codebase multiple times.
Impact:
33|38|36,38
Example:
contracts/token-to-price-feed.sol
36emit NewTokenPriceFeed(_token, _priceFeed, token.name(), token.symbol(), (DECIMAL_PRECISION * _mcr) / 100);Recommendation:
We advise it to be set to a constant variable instead optimizing the legibility of the codebase.
Alleviation:
The Bonq Protocol team has NOT made any changes in the source code to apply this optimization and as such, we consider it as acknowledged.