Omniscia Evergon Labs Audit

BurnFungibleForDiscountGenesisIdsFacetStorage Code Style Findings

BurnFungibleForDiscountGenesisIdsFacetStorage Code Style Findings

BFG-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.

Example:

packages/contracts/contracts/internalFacets/purchasePhaseFacets/purchaseDiscountFacets/genesisIds/burnForDiscount/BurnFungibleForDiscountGenesisIdsFacetStorage.sol
35/** ================================================== STORAGE =================================================
36 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
37 * STORAGE_SLOT: TO-DO
38 */
39bytes32 internal constant STORAGE_SLOT =
40 keccak256(
41 abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.BurnFungibleForDiscountGenesisIdsFacetStorage")) - 1)
42 ) & ~bytes32(uint256(0xff));

Recommendation:

We advise the 0x6f6d6242a946a77ed30a24c9c9c3e313a6a74573b63c8edc0c293e6c9dc8ae00 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.