Omniscia Evergon Labs Audit

StablePriceFacet Code Style Findings

StablePriceFacet Code Style Findings

SPF-01C: Redundant Function Implementation

Description:

The referred function implementation is redundant as it results in a no-op.

Example:

packages/contracts/contracts/genericFacets/priceFacets/stablePriceFacet/StablePriceFacet.sol
27function initPriceFacet(bytes calldata initPriceData) external onlyExternalDelegateCall {}

Recommendation:

We advise either the implementation to be omitted or its explicitly named function argument to have its name omitted.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The referenced function(s) apply modifier implementations considered crucial in derivative implementations, rendering this recommendation inapplicable.