Omniscia Evergon Labs Audit

PerpetuallyReceiveFundsFacet Code Style Findings

PerpetuallyReceiveFundsFacet Code Style Findings

PRF-01C: Redundant Function Implementations

TypeSeverityLocation
Gas OptimizationPerpetuallyReceiveFundsFacet.sol:
I-1: L15
I-2: L18

Description:

The referenced function implementations are redundant as they would result in a no-op.

Example:

packages/contracts/contracts/internalFacets/receivePhaseFacets/doReceiveFacets/perpetuallyReceiveFunds/PerpetuallyReceiveFundsFacet.sol
14/// @inheritdoc IDoReceiveFacet
15function initDoReceiveFacet(bytes calldata initDoReceiveData) external onlyExternalDelegateCall {}
16
17/// @inheritdoc IDoReceiveFacet
18function setAndCheckDoReceive(bytes calldata setAndCheckDoReceiveData) external onlyInternalDelegateCall {}

Recommendation:

We advise them to be omitted or their explicit variable names to be removed, either of which we consider acceptable.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The referenced function(s) apply modifier implementations considered crucial in derivative implementations, rendering this recommendation inapplicable.