Omniscia Evergon Labs Audit
PriceFeedMarginCallAmountFacet Code Style Findings
PriceFeedMarginCallAmountFacet Code Style Findings
PFM-01C: Improper Error Declaration
| Type | Severity | Location |
|---|---|---|
| Code Style |  | PriceFeedMarginCallAmountFacet.sol:L14 |
Description:
The referenced error declaration utilizes a camelCase convention instead of a PascalCase convention.
Example:
packages/contracts/contracts/subInternalFacets/marginCallPhaseFacets/marginCallAmountFacets/priceFeed/PriceFeedMarginCallAmountFacet.sol
14error packetsMarginAmountNotEnough(uint256 marginCallAmount, uint256 minimumAmountNeeded);Recommendation:
We advise the proper naming convention to be applied to it, optimizing the code's standardization.
Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):
The error declaration's naming convention has been corrected as advised.