Omniscia Evergon Labs Audit
LostAccountRoleEligibilityFacetStorage Code Style Findings
LostAccountRoleEligibilityFacetStorage Code Style Findings
LAE-01C: Inexistent Documentation of Storage Slot
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | LostAccountRoleEligibilityFacetStorage.sol:L21 |
Description:
The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.
Example:
packages/contracts/contracts/subInternalFacets/recoverFractionsPhaseFacets/lostAccountEligibilityFacets/roleEligibility/LostAccountRoleEligibilityFacetStorage.sol
19/** ================================================== STORAGE =================================================20 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.21 * STORAGE_SLOT: TO-DO22 */23bytes32 internal constant STORAGE_SLOT =24 keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.LostAccountRoleEligibilityFacetStorage")) - 1)) &25 ~bytes32(uint256(0xff));Recommendation:
We advise the 0x864f7d7453cf42076ed6932ffa8eeedd73b8ed0825a0e3645a2675bcb7e19400 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.
Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):
The correct storage slot has been specified as advised.
