Omniscia Evergon Labs Audit

PropPacketsGatheredFeeCollectorFacetStorage Code Style Findings

PropPacketsGatheredFeeCollectorFacetStorage Code Style Findings

PPC-01C: Inexistent Documentation of Storage Slot

Description:

The referenced STORAGE_SLOT does not have its actual result specified in its in-line documentation as it remains a TO-DO.

Example:

packages/contracts/contracts/privateFacets/doReceiveFacets/PropPacketsGatheredFeeCollectorFacetStorage.sol
34/**
35 * @dev Unique identifier for the storage slot where the Layout struct is stored. Derived from the ERC7201 formula.
36 * STORAGE_SLOT: TO-DO
37 */
38bytes32 internal constant STORAGE_SLOT =
39 keccak256(abi.encode(uint256(keccak256("Evergonlabs.Tmi-Tokenizer.storage.PropPacketsGatheredFeeCollectorFacetStorage")) - 1)) &
40 ~bytes32(uint256(0xff));

Recommendation:

We advise the 0x15baa3c44fe41b9879c79a1747c7f488e99ef4709259ef738d3f319f3a572e00 storage slot to be properly specified in its comments, aiding in debugging of the contract's structure.

Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):

The correct storage slot has been specified as advised.