Omniscia Myso Finance Audit
Errors Code Style Findings
Errors Code Style Findings
ESR-01C: Potential Error Usability Enhancement
Type | Severity | Location |
---|---|---|
Language Specific | Errors.sol:L5-L83 |
Description:
All error
declarations within the Errors
file do not contain any arguments, minimizing their off-chain usefulness.
Example:
contracts/Errors.sol
11error InsufficientSendAmount();
Recommendation:
Given that these errors are meant to be handled in debugging as well as in showing potential error messages to users, we advise them to include helpful arguments (i.e. InsufficientSendAmount
would yield the amount sent and the minimum amount accepted) significantly increasing their off-chain use.
Alleviation (c740f7c6b5ebd365618fd2d7ea77370599e1ca11):
The Myso Finance team has considered this exhibit but opted not to apply a remediation for it in the current iteration of the codebase.