Omniscia Myso Finance Audit
QuoteHandler Static Analysis Findings
QuoteHandler Static Analysis Findings
QHR-01S: Inexistent Sanitization of Input Address
| Type | Severity | Location |
|---|---|---|
| Input Sanitization |  | QuoteHandler.sol:L19-L21 |
Description:
The linked function accepts an address argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
contracts/peer-to-peer/QuoteHandler.sol
19constructor(address _addressRegistry) {20 addressRegistry = _addressRegistry;21}Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.
Alleviation (c740f7c6b5ebd365618fd2d7ea77370599e1ca11):
The input address of the QuoteHandler::constructor is properly sanitized against the zero address in the latest implementation, ensuring that the contract cannot be accidentally misconfigured during its deployment.