Omniscia Nuklai Audit
Code Style
Code Style
During the manual portion of the audit, we identified 22 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| AMV-01C |  |  | Inefficient Contract Import |
| DFY-01C | | | Inefficient Contract Imports |
| DNF-01C | | | Duplicate Invocation of Getter Function |
| DNF-02C | | | Inefficient mapping Lookups |
| DNF-03C | | | Loop Iterator Optimization |
| DMR-01C | | | Inefficient Loop Limit Evaluations |
| DMR-02C | | | Loop Iterator Optimizations |
| DMR-03C | | | Redundant Function Argument |
| DMR-04C | | | Repetitive Value Literals |
| FNF-01C | | | Duplicate Invocation of Getter Functions |
| FNF-02C | | | Ineffectual Usage of Safe Arithmetics |
| FNF-03C | | | Inefficient Loop Limit Evaluation |
| FNF-04C | | | Inefficient Maintenance of Account Snapshots |
| FNF-05C | | | Inefficient mapping Lookups |
| FNF-06C | | | Loop Iterator Optimizations |
| GSD-01C | | | Ineffectual Usage of Safe Arithmetics |
| GSD-02C | | | Inefficient Loop Limit Evaluation |
| GSD-03C | | | Inexistent Event Indexing |
| GSD-04C | | | Loop Iterator Optimizations |
| GSD-05C | | | Repetitive Value Literals |
| VMR-01C | | | Inexistent Event Indexing |
| VMR-02C | | | Loop Iterator Optimization |