Omniscia Nuklai Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Nuklai's Data Tunnel implementation.
As the project at hand implements a data-contribution system that permits users to subscribe to off-chain data flows, intricate care was put into ensuring that the flow of funds & assets within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple significant vulnerabilities within the system which could have had severe ramifications to its overall operation; we strongly advise the Nuklai team to promptly remediate them.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a great extent, containing extensive in-line documentation as well as supplemental resources in the code repository.
A total of 34 findings were identified over the course of the manual review of which 12 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| AMV-01M |  |  | Insecure Utilization of Fragment NFT |
| DNF-01M |  | | Improper Enforcement Flow of Deployer Fees |
| DNF-02M | | | Inexistent Sanitization of Sensitive Module Implementations |
| DNF-03M | | | Insecure Signature Validation |
| DMR-01M |  | | Incompatibility of Fee-Based Tokens |
| DMR-02M | | | Incorrect Initialization Methodology |
| DMR-03M | | | Potential Loss of Funds |
| ERC-01M | | | Inexistent Prevention of Native Funds |
| FNF-01M | | | Proposal Tag ID Corruption Re-Entrancy |
| GSD-01M | | | Incorrect Restriction of Subscription Extension |
| GSD-02M |  | | Inexistent Surcharge Protection of Subscriber |
| GSD-03M | | | Incorrect Dependency Set |