Omniscia Nuklai Audit

AcceptManuallyVerifier Code Style Findings

AcceptManuallyVerifier Code Style Findings

AMV-01C: Inefficient Contract Import

Description:

The AcceptManuallyVerifier contract will contain an inflated bytecode size as it imports the full VerifierManager implementation even though it is solely utilized as an interface.

Example:

contracts/verifier/AcceptManuallyVerifier.sol
8import {VerifierManager} from "./VerifierManager.sol";

Recommendation:

We advise a proper interface to be coded for the relevant contract (i.e. IVerifierManager) and to be imported to the AcceptManuallyVerifier, minimizing its deployed bytecode size.

Alleviation (fb50b5c39665f7df086b2de1fdbf93ba2d836bf9):

The referenced contract import has been replaced by a newly introduced IVerifierManager interface as advised, optimizing the bytecode size of the contract significantly.