Omniscia Nuklai Audit
DatasetNFT Static Analysis Findings
DatasetNFT Static Analysis Findings
DNF-01S: Data Location Optimizations
Type | Severity | Location |
---|---|---|
Gas Optimization | DatasetNFT.sol:L283, L284 |
Description:
The linked input arguments are set as memory
in external
function(s).
Example:
contracts/DatasetNFT.sol
281function proposeManyFragments(282 uint256 datasetId,283 address[] memory owners,284 bytes32[] memory tags,285 bytes calldata signature286) external {
Recommendation:
We advise them to be set as calldata
optimizing their read-access gas cost.
Alleviation (fb50b5c39665f7df086b2de1fdbf93ba2d836bf9):
The DatasetNFT::proposeManyFragments
function's eligible input arguments have been properly set to calldata
, optimizing their read-access gas cost.