Omniscia Swisscoast Audit

Code Style

Code Style

During the manual portion of the audit, we identified 27 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BHS-01CInefficient Function Implementation
BOS-01CRedundant Duplicate Member
GPL-01CDeprecated Empty Revert
GPL-02CVariable Mutability Specifiers (Immutable)
HCH-01CDeprecated Revert Pattern
HCH-02CInefficient Function Implementation
HCH-03CInefficient Negation of Conditional
HCH-04CRedundant Function Implementation
HCH-05CVariable Mutability Specifier (Immutable)
HLQ-01CDeprecated Revert Pattern
HLQ-02CInefficient Function Implementation
HLQ-03CInefficient Negation of Conditional
HLQ-04CPotentially Incorrect Token Name / Symbol
HLQ-05CRedundant Function Implementation
HLQ-06CVariable Mutability Specifier (Immutable)
PFD-01CRedundant Parenthesis Statements
PCR-01CDeprecated Revert Pattern
PCR-02COptimization of Returned Arguments
PCR-03CRepetitive Value Literal
PCR-04CVariable Mutability Specifier (Immutable)
SCT-01CRedundant Library Implementation
SER-01CIncorrect & Unused Library Implementation
SCR-01CImproper Return Arguments
SCR-02CInefficient Integration of Supra
SCR-03COptimization of Returned Arguments
SCR-04CVariable Mutability Specifier (Immutable)
TMR-01CRedundant Duplicate Member

Prev

Manual Review

Next

GasPool.sol (GPL-S)