PythCaller Code Style Findings

PCR-01C: Deprecated Revert Pattern

Type	Severity	Location
Code Style		PythCaller.sol:L66

Description:

The referenced statement will issue an empty revert.

Example:

Copy
65if (price < 0 || expo > 0 || expo < -255) {
66    revert();
67}

Recommendation:

We advise a require check with an accompanying message to be introduced, increasing the legibility of the check.

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

As part of alleviations for PCR-01M, the code will issue a return statement instead of a revert indirectly addressing this exhibit.

PCR-02C: Optimization of Returned Arguments

Type	Severity	Location
Gas Optimization		PythCaller.sol:L56-L57

Description:

The referenced code block will inefficiently implement two different return statements.

Example:

Copy
56if (hbarChfPrice > 0) return (true, hbarChfPrice, publishTime);
57return (false, 0, publishTime);

Recommendation:

We advise a single return statement to be present, with the first argument being the result of hbarChfPrice > 0, the second argument being the hbarChfPrice result itself, and the final argument being the publishTime.

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

The referenced return statements were optimized into one as advised.

PCR-03C: Repetitive Value Literal

Type	Severity	Location
Code Style		PythCaller.sol:L48, L49

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

Copy
48uint256 basePriceHBARUSD = convertToUint(priceHBARUSD, expoHBARUSD, 8);

Recommendation:

We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.

In case the constant has already been declared, we advise it to be properly re-used across the code.

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

The Swisscoast team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase

PCR-04C: Variable Mutability Specifier (Immutable)

Type	Severity	Location
Gas Optimization		PythCaller.sol:L20

Description:

The linked variable is assigned to only once during the contract's constructor.

Example:

Copy
20IPyth public pyth;
21
22constructor (address _pythAddress) public {
23    pyth = IPyth(_pythAddress);
24}

Recommendation:

We advise it to be set as immutable greatly optimizing its read-access gas cost.

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

The pyth contract-level variable of the contract has been set as immutable, optimizing its read-access gas cost significantly.