Omniscia Swisscoast Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the delta of the codebase to identify potential malfunctions and vulnerabilities in Swisscoast's Hedera-targeted Liquity fork.
As the project at hand implements a delta from an original implementation that introduces Hedera-related functionality, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that the integration of Hedera-related modules (i.e. the Hedera Token Service) has been securely performed.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple oracle-related vulnerabilities within the system which could have had severe ramifications to its overall operation; we urge the Swisscoast team to closely evaluate and remediate them.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 47 findings were identified over the course of the manual review of which 20 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| HCH-01M |  |  | Inefficient Auto-Renewal Period |
| HCH-02M | | | Insecure Subtraction of Balances |
| HCH-03M |  |  | Inexistent Bypass of Authorization |
| HCH-04M |  |  | Inexistent Acceptance of Native Funds |
| HLQ-01M |  | | Inexistent Restrictions of Multi-Signature Wallet |
| HLQ-02M | | | Inefficient Auto-Renewal Period |
| HLQ-03M | | | Inexistent Enforcement of Transfer-Related Restrictions |
| HLQ-04M | | | Insecure Subtraction of Balances |
| HLQ-05M | | | Inexistent Bypass of Authorization |
| HLQ-06M | | | Inexistent Acceptance of Native Funds |
| KLB-01M | | | Inexistent Validation of Non-Zero Address |
| KLB-02M | | | Insecure Offset of Key Bit |
| LUS-01M | | | Improper Conversion Mechanism |
| PCR-01M | | | Improper Revert Error |
| PCR-02M | | | Insecure Price Acquisition |
| PCR-03M |  | | Incorrect Accuracy of Yielded Value |
| SCR-01M | | | Improper Handling of Decimals |
| SCR-02M | | | Incorrect Accuracy of Yielded Value |
| TST-01M | | | Potentially Incorrect Token Script Integration |
| ULO-01M | | | Inexplicable Reduction of Accuracy |