HCHFToken Static Analysis Findings

HCH-01S: Illegible Numeric Value Representation

Type	Severity	Location
Code Style		HCHFToken.sol:L58

Description:

The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
58token.expiry = createAutoRenewExpiry(address(this), 8000000);

Recommendation:

To properly illustrate the value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

The referenced value literal has been updated in its representation to 7_776_000 in accordance with the recommendation's underscore style, addressing this exhibit.