LUSDUsdToLUSDEth Manual Review Findings

LUS-01M: Improper Conversion Mechanism

Type	Severity	Location
Language Specific		LUSDUsdToLUSDEth.sol:L11, L12

Description:

The LUSDUsdToLUSDEth contract was developed in the original Liquity protocol after its launch as it integrates with an LUSD oracle whose HCHF equivalent does not exist in the HLiquity project.

Impact:

We consider the Swisscoast team aware of this limitation, however, we noticed the introduction of a comment and wished to denote that the present code should not be considered as deployment-ready.

Example:

Copy
10contract LUSDUsdToLUSDEth is IPriceFeed {
11    IPriceFeed public constant LUSD_USD = IPriceFeed(0x3D7aE7E594f2f2091Ad8798313450130d0Aba3a0);
12    IPriceFeed public constant ETH_USD = IPriceFeed(0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419); //HBAR-USD
13
14    constructor() public {}
15
16    function latestAnswer() external view override returns (int256) {
17        return (LUSD_USD.latestAnswer() * 1 ether) / ETH_USD.latestAnswer();
18    }
19}

Recommendation:

We advise the contract to be removed / commented out, and to be developed at a later stage once the relevant data fees are available.

Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):

The file specified by the exhibit is no longer present in the codebase rendering it inapplicable.