Omniscia Swisscoast Audit
GasPool Static Analysis Findings
GasPool Static Analysis Findings
GPL-01S: Inexistent Visibility Specifiers
Type | Severity | Location |
---|---|---|
Code Style | GasPool.sol:L23, L24 |
Description:
The linked variables have no visibility specifier explicitly set.
Example:
packages/contracts/contracts/GasPool.sol
23address troveManagerAddress;
Recommendation:
We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma
versions.
Alleviation (04618e407bddce5b22e9cadd787fd3334bd3afe6):
The public
visibility specifier has been introduced to all referenced variables, preventing potential compilation discrepancies and addressing this exhibit.