Omniscia rain protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 25 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
ID | Severity | Addressed | Title |
---|---|---|---|
COO-01C | Potential Mutability Optimization | ||
ERF-01C | Suboptimal Visibility Specifier | ||
ERC-01C | Redundant Evaluation of Multiple Assertions | ||
ERT-01C | Optimized Value Usage | ||
ERT-02C | Redundant Usage of Saturating Subtractions | ||
ECT-01C | Incorrect Event Argument | ||
FAC-01C | Redundant Code Block Declaration | ||
MOS-01C | Unoptimized Stack Index Adjustment | ||
PHA-01C | Phase Consistency | ||
PHA-02C | Type Casting Optimization | ||
RVM-01C | Documentation Typo | ||
RER-01C | Non-Standard Error Capture | ||
SMH-01C | Deviation of Comment Style | ||
SER-01C | Potential Legibility Optimization | ||
SER-02C | Potentially Convoluted Redemption Protection Mechanism | ||
SEC-01C | Suboptimal Visibility Specifier | ||
TBC-01C | Potential Mutability Optimization | ||
TOP-01C | Potential Misuse of Select LTE Instruction | ||
TOP-02C | Unoptimized Stack Index Adjustment | ||
TRT-01C | Redundant Maximum Tier Enforcement | ||
TCE-01C | Potential User-Defined Value Type | ||
TRU-01C | Error Message Typo | ||
TFY-01C | Non-Standard Implementation Deployment Check | ||
VTR-01C | Mathematical Optimization | ||
VER-01C | RBAC Documentation Discrepancy |