Omniscia rain protocol Audit
Verify Code Style Findings
Verify Code Style Findings
VER-01C: RBAC Documentation Discrepancy
Type | Severity | Location |
---|---|---|
Code Style | Verify.sol:L236 |
Description:
The linked comment states that the DEFAULT_ADMIN_ROLE
is present in the contract's RBAC system which is untrue.
Example:
contracts/verify/Verify.sol
235// It is STRONGLY RECOMMENDED that the `admin_` delegates specific236// admin roles then revokes the `DEFAULT_ADMIN_ROLE` and the `X_ADMIN`237// roles.
Recommendation:
We advise the comment and all relevant other bits to be adjusted to omit the reference to the default administrator role of AccessControl
as it is not assigned in the codebase.
Alleviation:
The documentation was updated to no longer mention the special DEFAULT_ADMIN_ROLE
as advised.