Omniscia rain protocol Audit

ERC20TransferTierFactory Code Style Findings

ERC20TransferTierFactory Code Style Findings

ECT-01C: Incorrect Event Argument

Description:

The linked event emission improperly references the implementation stored at the contract level which is equivalent to zero at the time of execution.

Example:

contracts/tier/ERC20TransferTierFactory.sol
15/// Build the reference implementation to clone for each child.
16constructor() {
17 address implementation_ = address(new ERC20TransferTier());
18 emit Implementation(msg.sender, implementation);
19 implementation = implementation_;
20}

Recommendation:

We advise the proper underscore (_) suffixed argument to be utilized instead.

Alleviation:

The proper argument is now emitted by the Implementation event.