Factory Code Style Findings

FAC-01C: Redundant Code Block Declaration

Type	Severity	Location
Code Style		Factory.sol:L32

Description:

The linked code block declaration following a virtual function is redundant.

Example:

Copy
28function _createChild(bytes calldata data_)
29    internal
30    virtual
31    returns (address)
32{} // solhint-disable-line no-empty-blocks

Recommendation:

We advise the declaration of the function signature to be suffixed with the statement terminal character (;) instead of an empty code block ({}), fulfilling the same purpose and standardizing the code style according to the official Solidity style guide.

Alleviation:

The Rain Protocol team considered this exhibit but opted not to apply a remediation for it in the current iteration of the codebase.