BasicVault Code Style Findings

BVT-01C: Generic Typographic Mistakes

Type	Severity	Location
Code Style		BasicVault.sol:L19, L20, L21, L22, L51, L52, L53

Description:

The referenced lines contain typographical mistakes (i.e. private variable without an underscore prefix) or generic documentational errors (i.e. copy-paste) that should be corrected.

Example:

Copy
19IERC20 _asset;

Recommendation:

We advise them to be corrected enhancing the legibility of the codebase.

Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):

All referenced variables have been renamed accordingly, omitting their underscore prefix for the sake of legibility as they do not constitute actual private / internal variables.

BVT-02C: Non-Standard Library Usage

Type	Severity	Location
Code Style		BasicVault.sol:L147, L165

Description:

The referenced statements will utilize the SafeERC20 library directly instead of via its using SafeERC20 for IERC20 syntax.

Example:

Copy
147SafeERC20.safeTransferFrom($._asset, _msgSender(), address(this), added);

Recommendation:

We advise the code to instead employ the syntax aforementioned, optimizing the legibility of the code greatly.

Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):

The SafeERC20 library is now utilized properly throughout the contract, addressing this exhibit.