Omniscia Mitosis Audit
BasicVaultFactory Code Style Findings
BasicVaultFactory Code Style Findings
BVF-01C: Generic Typographic Mistakes
| Type | Severity | Location |
|---|---|---|
| Code Style |  | BasicVaultFactory.sol:L19, L20, L21, L22, L23 |
Description:
The referenced lines contain typographical mistakes (i.e. private variable without an underscore prefix) or generic documentational errors (i.e. copy-paste) that should be corrected.
Example:
19UpgradeableBeacon _beacon;Recommendation:
We advise them to be corrected enhancing the legibility of the codebase.
Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):
All referenced variables have been renamed accordingly, omitting their underscore prefix for the sake of legibility as they do not constitute actual private / internal variables.
BVF-02C: Loop Iterator Optimization
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | | BasicVaultFactory.sol:L85 |
Description:
The linked for loop increments / decrements the iterator "safely" due to Solidity's built-in safe arithmetics (post-0.8.X).
Example:
85for (uint256 i = 0; i < ids.length; i++) {Recommendation:
We advise the increment / decrement operation to be performed in an unchecked code block as the last statement within the for loop to optimize its execution cost.
Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):
The referenced loop iterator's increment statement has been relocated at the end of the for loop's body and has been unwrapped in an unchecked code block, optimizing its gas cost.