Omniscia Mitosis Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Mitosis' cross-chain system.
As the project at hand implements a Hyperlane based cross-chain vault system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple cross-chain related vulnerabilities within the system which could have had severe ramifications to its overall operation; we urge the Mitosis team to promptly evaluate and remediate them.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 60 findings were identified over the course of the manual review of which 36 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
ATM-01M | Inexistent Initialization Protection of Base Implementation | ||
ATM-02M | Inexplicable Fallback Function | ||
ABA-01M | Inexistent Initialization Protection of Base Implementation | ||
ABA-02M | Inexistent Approval of Bridged Assets | ||
BVT-01M | Bypass of Halt Restrictions | ||
BVT-02M | Improper Deposit Log Maintenance | ||
BVT-03M | Inexistent Initialization Protection of Base Implementation | ||
BVT-04M | Inexistent Consumption of Allowance | ||
BVT-05M | Improper Assumption of Binary Search | ||
BVT-06M | Improper Protection Against EIP-777 Re-Entrancies | ||
BVF-01M | Inexistent Initialization Protection of Base Implementation | ||
BVF-02M | Insufficient Prevention of Vault Deployment | ||
CCM-01M | Inexistent Initialization Protection of Base Implementation | ||
CCM-02M | Improper Refund Fee Acquisition | ||
CCM-03M | Unhandled Failure of Cross-Chain Message | ||
CCD-01M | Inexistent Initialization Protection of Base Implementation | ||
CCD-02M | Improper Refund Processing | ||
CCD-03M | Incorrect Validation of Native Funds | ||
CCD-04M | Incorrect Approval Operation | ||
CPA-01M | Inexistent Initialization Protection of Base Implementation | ||
CPA-02M | Inexistent Validation of Ascending Cap Order | ||
CPA-03M | Inexistent Validation of Epoch Configuration | ||
CPA-04M | Trivial Epoch Advancement | ||
CPA-05M | Incorrect Initialization of Minimum-Value Search | ||
CVN-01M | Unsafe Address Casting | ||
EET-01M | Inexistent Initialization Protection of Base Implementation | ||
EET-02M | Potentially Insecure Approval Operations | ||
ETN-01M | Empty Contract / TODO | ||
MEG-01M | Incorrect Message Type Encodings | ||
OBA-01M | Inexistent Initialization Protection of Base Implementation | ||
OBA-02M | Inexistent Approval of Bridged Assets | ||
PZE-01M | Inexistent Initialization Protection of Base Implementation | ||
PZE-02M | Inexistent Claim of Bridged Assets | ||
PZE-03M | Inexistent Approval of Bridged Assets | ||
VHB-01M | Inexistent Initialization Protection of Base Implementation | ||
VHB-02M | Potentially Dangerous Invocation |