Omniscia Mitosis Audit
BasicVaultFactory Static Analysis Findings
BasicVaultFactory Static Analysis Findings
BVF-01S: Inexistent Event Emission
| Type | Severity | Location |
|---|---|---|
| Language Specific |  | BasicVaultFactory.sol:L132-L134 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
src/vault/BasicVaultFactory.sol
132function updateHub(address hub) external onlyOwner {133 _getStorageV1()._hub = hub;134}Recommendation:
We advise an event to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):
The HubUpdated event was introduced to the codebase and is correspondingly emitted in the BasicVaultFactory::updateHub function, addressing this exhibit in full.