VaultHub Static Analysis Findings

VHB-01S: Inexistent Event Emissions

Type	Severity	Location
Language Specific		VaultHub.sol:L52-L56, L58-L62

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

Copy
52function setFactory(VaultType vaultType, address factory_) external onlyOwner {
53    StorageV1 storage $ = _getStorageV1();
54
55    $._factories[vaultType] = factory_;
56}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

Alleviation (58e8cc66dfa900c03c47df78f5170d9960005629):

The FactorySet, and FactoryDeleted events were introduced to the codebase and are correspondingly emitted in the VaultHub::_setFactory, and VaultHub::_delFactory functions respectively, addressing this exhibit in full.