Omniscia Olympus DAO Audit
Code Style
Code Style
During the manual portion of the audit, we identified 34 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BDY-01C | Informational | No | Improper Error Messages |
| BDY-02C | Informational | No | Inexistent Error Messages |
| BDY-03C | Informational | No | Potentially Misleading USD Evaluation |
| BDY-04C | Informational | No | Redundant Explicit Zero-Value Assignment |
| BTR-01C | Informational | Yes | Inexistent Variable Visibility Specifiers |
| ERC-01C | Informational | Yes | Variable Mutability Specifier |
| ERP-01C | Informational | Yes | Improper Error Name |
| ERP-02C | Informational | Yes | Redundant Visibility Specifiers |
| ERP-03C | Informational | Yes | Suboptimal Code Style |
| FMH-01C | Informational | Yes | Outdated Implementation |
| GOV-01C | Informational | Yes | Inexistent Deletion of Pending Governor |
| GUA-01C | Informational | Yes | Inexistent Deletion of Pending Guardian |
| MOE-01C | Informational | Yes | Redundant Implementation |
| OER-01C | Informational | Yes | Incorrect Function Visibility |
| OTM-01C | Informational | Yes | Inexistent Error Messages |
| OTM-02C | Informational | Yes | Multiple Top-Level Declarations |
| OTM-03C | Informational | No | Redundant & Confusing Comparisons |
| OWN-01C | Informational | Yes | Inexistent Deletion of Pending Owner |
| SMH-01C | Informational | No | Inefficient Implementation |
| SDR-01C | Informational | Yes | Inexistent Error Messages |
| SDR-02C | Informational | Yes | Inexistent Variable Visibility Specifiers |
| SBC-01C | Informational | Yes | Inexistent Error Message |
| SBC-02C | Informational | Yes | Inexistent Variable Visibility Specifier |
| TIM-01C | Informational | Yes | Redundant Implementation |
| TRE-01C | Informational | Yes | Improper Failure Enforcement |
| TRE-02C | Informational | Yes | Improper Permitted Execution Flow |
| TRE-03C | Informational | Yes | Inexistent Error Messages |
| TRE-04C | Informational | Yes | Inexistent Variable Visibility Specifier |
| OHM-01C | Informational | Yes | Inexistent Error Messages |
| OEC-01C | Informational | Yes | Deprecated Representation Style |
| OEC-02C | Informational | Yes | Inefficient Code Structure |
| OEC-03C | Informational | Yes | Inexistent Error Messages |
| OEC-04C | Informational | No | Inexistent Variable Visibility Specifiers |
| OEC-05C | Informational | Yes | Redundant Event Argument |