Omniscia Olympus DAO Audit

ManagerOwnable Code Style Findings

ManagerOwnable Code Style Findings

MOE-01C: Redundant Implementation

TypeSeverityLocation
Code StyleInformationalManagerOwnable.sol:L7-L10

Description:

The ManagerOwnable contract is redundant as it declares a new modifier labelled onlyManager that is exactly the same as the onlyOwner modifier, inclusive of the error messages.

Example:

contracts/types/ManagerOwnable.sol
4import "./Ownable.sol";
5
6contract ManagerOwnable is Ownable {
7 modifier onlyManager() {
8 require( _owner == msg.sender, "Ownable: caller is not the owner" );
9 _;
10 }
11}

Recommendation:

We advise the implementation to be omitted from the codebase entirely.

Alleviation:

The contract is no longer part of the codebase rendering this exhibit null.