StandardBondingCalculator Code Style Findings

SBC-01C: Inexistent Error Message

Description:

The linked require check contains no descriptive error message.

Example:

Copy
26require( _OHM != address(0) );

Recommendation:

We advise one to be set so to aid in the debugging of the application and to also enable more accurate validation of the require condition's purpose.

Alleviation:

Error messages were introduced in all linked require checks.

SBC-02C: Inexistent Variable Visibility Specifier

Description:

The linked variable has no visibility specifier explicitly set.

Example:

Copy
23IERC20 immutable OHM;

Recommendation:

We advise one to be set so to avoid potential compilation discrepancies in the future as the current compiler behaviour is to assign a specifier automatically.

Alleviation:

The internal visibility specifier was properly introduced to the linked variable.