FixedPoint Manual Review Findings

FPT-01M: Potentially Invalid Implementation

Description:

The decode112with18 function is non-standard, utilizes a value literal and cannot be validated as to its purpose.

Example:

Copy
110function decode112with18(uq112x112 memory self) internal pure returns (uint) {
111
112    return uint(self._x) / 5192296858534827;
113}

Recommendation:

We advise it to be extensively documented as in its current state it is ambiguous. This finding will be adjusted accordingly when the code segment has been properly documented.

Alleviation:

The Olympus DAO team has not provided a response for this exhibit yet.